Author Topic: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013  (Read 35094 times)

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #120 on: November 01, 2014, 05:30:28 PM »
When they move to peer id show them this:  https://github.com/qbittorrent/qBittorrent/wiki/Frequently-Asked-Questions#What_is_qBittorrent_Peer_ID

This is the particular line from qbt source for user agent:
Code: [Select]
sessionSettings.user_agent = "qBittorrent "VERSION;
and VERSION is defined as:
Code: [Select]
v3.1.11
Maybe a wireshark capture would shed some light on that.

Muzak

  • Veteran
  • ***
  • Posts: 78
  • Karma: +2/-0
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #121 on: November 03, 2014, 07:42:43 PM »
Thanks, I'll probably have to wireshark it, something funky is going on, probably something with my connection....

Muzak

  • Veteran
  • ***
  • Posts: 78
  • Karma: +2/-0
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #122 on: November 05, 2014, 06:13:20 PM »
Turns out they were using the Peer ID and had some regx code to split the peer id up and it broke on having a letter in the version.   Took me quite a bit of head scratching to come up with the fix, but all is good now, they updated the code and it's all good.....  Did I mention how much I hate regx????

FWIW, the current PeerId for 3.1.10 and 3.1.11 violate the "convention" for peer ids (I just received a mini-education on why my patch was wrong, even though it wasn't....hehehe)
https://wiki.theory.org/BitTorrentSpecification#peer_id
« Last Edit: November 05, 2014, 11:02:26 PM by Muzak »

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #123 on: November 09, 2014, 12:29:26 AM »
I think the keyword here is "ascii digits".

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #124 on: November 09, 2014, 12:44:25 AM »
Yeap. Here is an excerpt from include/libtorrent/fingerprint.hpp (libtorrent 1.0.3):

Code: [Select]
char version_to_char(int v) const
{
if (v >= 0 && v < 10) return '0' + v;
else if (v >= 10) return 'A' + (v - 10);
TORRENT_ASSERT(false);
return '0';
}

Libtorrent allows to construct the peer id by providing the fingerprint class a 2 character string, and 4 integers for major,minor,revision,tag versions. Each interger is converted to ascii using the above function.
Numbers 0-9 are converted to their equivalent ascii code(aka number).
All others are converted to the ascii code of 'A' plus their number.(minus 10).
Note: In C/C++ when you enclose something in single quotes it is treated as a character not as a number. So in this case '0' converted to number means 48 (the ascii code for zero).

EDIT: variables of type char can be treated in 2 ways: represent an actual character or represent a number(255 possible values).
« Last Edit: November 09, 2014, 12:46:03 AM by sledgehammer_999 »

KManju

  • Newbie
  • *
  • Posts: 1
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #125 on: February 11, 2015, 11:30:01 PM »
I'm not sure if this is the right place to ask this, but I am new to the forums and qBittorrent, and haven't had a chance to fully explore. I know that with some torrent clients, the 12 bytes of padding in the peer id are static and are used as a unique id of sorts. I was wondering if this was the case with 3.1.11, and if so, is there anyway to change it other than enabling the 'anonymous mode' which unfortunately disables DHT and PEX.

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #126 on: February 12, 2015, 03:29:23 PM »
The padding should be random. At least that is what the libtorrent docs say.
There is no way for an end-user to spoof the peer-id. (qbt would be banned immediately by every tracker if there was such a possibility).
I am not sure, but I think libtorrent 1.0.x allows dht/pex with anonymous mode. You should try the alpha builds in the "windows development" section of the forum. They use libtorrent 1.0.x. (the v3.1.x series aren't compatible with that)

Muzak

  • Veteran
  • ***
  • Posts: 78
  • Karma: +2/-0
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #127 on: February 12, 2015, 05:54:20 PM »
Per libtorrent the 12 bytes are random each time you start the client.  They don't change until you close and reopen the client.  Most sites frown on this being changed during the client session.

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #128 on: February 23, 2015, 01:16:10 AM »
Here is qBittorrent 3.1.12 built with MSVC 2013 express.

3.1.12 link-> http://www.fosshub.com/qBittorrent.html
Changelog: http://www.qbittorrent.org/news.php

Libraries's version used:
Libtorrent: 0.16.19+svn10736
Qt: 4.8.6
Boost: 1.55.0

As you may have noticed I have changed to using msvc 2013 instead of msvc 2008(these are compilers). I want Windows XP users to tell me if it works on their system. I tested it on a clean Windows XP VM and it works for me.

Henry63

  • Member
  • **
  • Posts: 39
  • Karma: +2/-0
    • View Profile
Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013
« Reply #129 on: February 23, 2015, 02:42:00 AM »
I just installed Win8.1 yesterday and 3.1.11 installed just fine but 3.1.12 is making Win8.1 want to block the install program from running. Claims it's "unsafe". I assume it's a false positive of some sort.

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013
« Reply #130 on: February 23, 2015, 03:02:25 AM »
I just installed Win8.1 yesterday and 3.1.11 installed just fine but 3.1.12 is making Win8.1 want to block the install program from running. Claims it's "unsafe". I assume it's a false positive of some sort.

Are you refering to the UAC dialog or to some kind of antivirus warning?
In the past some antivirus programs gave false positives for our installers... This might be it. My avast shows it as clean.

Henry63

  • Member
  • **
  • Posts: 39
  • Karma: +2/-0
    • View Profile
Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013
« Reply #131 on: February 23, 2015, 03:26:58 AM »
I just have a stock Pro install(no custom anti-malware or anything, just games and "normal" programs), but it was like a UAC thing, where the entire screen turned grey and a message bar went across the middle saying that the program was blocked. MsMpEng has been running in the background for a quite a while now, from what I found, it's probably "learning" the new system.

I just recently tried it again and it is no longer being blocked, but I did try it a few times before originally posting. I guess I'll just assume MsMpEng was being overly paranoid or something. I kicked off a full scan, I read this can help it learn faster or something.

tekko

  • Guest
Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008
« Reply #132 on: February 23, 2015, 04:50:55 PM »
Here is qBittorrent 3.1.12 built with MSVC 2013 express.

3.1.12 link-> http://www.fosshub.com/qBittorrent.html
Changelog: http://www.qbittorrent.org/news.php

Libraries's version used:
Libtorrent: 0.16.19+svn10736
Qt: 4.8.6
Boost: 1.55.0

As you may have noticed I have changed to using msvc 2013 instead of msvc 2008(these are compilers). I want Windows XP users to tell me if it works on their system. I tested it on a clean Windows XP VM and it works for me.


xpsp3... main os, not vm
no problem yet.

Nemo

  • qBittorrent Forum
  • Administrator
  • Forum addict
  • *****
  • Posts: 1466
  • Karma: +90/-0
    • View Profile
Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013
« Reply #133 on: February 23, 2015, 07:29:51 PM »
Thanks sledge.
Forum Rules and Guidelines

Forum Admin.
Dutch & Turkish Translator.




100%

  • Veteran
  • ***
  • Posts: 88
  • Karma: +4/-0
    • View Profile
Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013
« Reply #134 on: February 24, 2015, 01:23:25 PM »
qBt v3.1.12 is working great, thanks guys!