Author Topic: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013  (Read 35095 times)

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #15 on: November 06, 2013, 01:35:34 AM »
Here is qBittorrent 3.1.2 built with MSVC 2008 express.

3.1.2 link-> http://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/qbittorrent-3.1.2/qbittorrent_3.1.2_setup.exe/download
Changelog: http://www.qbittorrent.org/news.php

Libraries's version used:
Libtorrent: 0.16.12+svn9273
Qt: 4.8.5
Boost: 1.54.0

100%

  • Veteran
  • ***
  • Posts: 88
  • Karma: +4/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #16 on: November 06, 2013, 05:23:09 PM »
Thanks sledge, you're the man! ;)

Doadin

  • Newbie
  • *
  • Posts: 10
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #17 on: November 09, 2013, 04:23:37 AM »
Hello, im not sure if this is the place to post but with the last two recent builds.(may have come earlier too but just started using qbittorrent recently) I have been having a problem with in the Execution Log Blocked IPs tab its showing blocked IPs. Now that would be good except i have ipfilter disabled. I tried toggling it same result. I also tried loading a blank filter and toggling it again same result. How can i disable it or clear the filter?

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #18 on: November 14, 2013, 12:01:56 AM »
Hello, im not sure if this is the place to post but with the last two recent builds.(may have come earlier too but just started using qbittorrent recently) I have been having a problem with in the Execution Log Blocked IPs tab its showing blocked IPs. Now that would be good except i have ipfilter disabled. I tried toggling it same result. I also tried loading a blank filter and toggling it again same result. How can i disable it or clear the filter?

Libtorrent blocks bad ips too, based on several facts. The most common one is when a peer sends bad data regularly.

loki

  • Forum addict
  • ****
  • Posts: 567
  • Karma: +16/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #19 on: November 14, 2013, 07:55:58 AM »
It does clear the filter when restarted?

Doadin

  • Newbie
  • *
  • Posts: 10
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #20 on: November 14, 2013, 11:46:52 PM »
Hello, im not sure if this is the place to post but with the last two recent builds.(may have come earlier too but just started using qbittorrent recently) I have been having a problem with in the Execution Log Blocked IPs tab its showing blocked IPs. Now that would be good except i have ipfilter disabled. I tried toggling it same result. I also tried loading a blank filter and toggling it again same result. How can i disable it or clear the filter?

Libtorrent blocks bad ips too, based on several facts. The most common one is when a peer sends bad data regularly.

ok so its not an ipfilter rule even though thats what it says? Is there not a way to distinguish between libtorrent blocking and blocking done by the ipfilter.(Kinda of confusing) If not maybe change the message to a more generic message like "*ip* was blocked."

Looking through the source it looks like this:
@/src/qtlibtorrent/qbtsession.cpp:1679
  if (from_ipfilter)
    msg = "<font color='grey'>" + QDateTime::currentDateTime().toString(QString::fromUtf8("dd/MM/yyyy hh:mm:ss")) + "</font> - " + tr("<font color='red'>%1</font> <i>was blocked due to your IP filter</i>", "x.y.z.w was blocked").arg(ip);

Is whats happening. (The only place i found so far with that message lot of code though maybe i just havent gotten to it) Again though if it includes libtorrents blocking then maybe a more generic message would be more appropriate.
« Last Edit: November 15, 2013, 12:47:14 AM by Doadin »

Doadin

  • Newbie
  • *
  • Posts: 10
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #21 on: November 17, 2013, 11:18:06 PM »
If this is the only place "was blocked due to your IP filter" then it is infact a bug because i shouldnt be getting this message ever since i dont have a ipfilter set. And therefore if (from_ipfilter) should never be true.
« Last Edit: November 17, 2013, 11:20:21 PM by Doadin »

Dayman

  • Administrator
  • Veteran
  • *****
  • Posts: 343
  • Karma: +45/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #22 on: November 18, 2013, 04:30:56 PM »
    Unfortunately it is not possible to distinguish the source of peer block.

    libtorrent sends peer_blocked_alert in any of these circumstances:
    • the IP filter
    • i2p mixed mode restrictions (a normal peer is not allowed on an i2p swarm)
    • the port filter
    • the peer has a low port and no_connect_privileged_ports is enabled
    • the protocol of the peer is blocked (uTP/TCP blocking)

    peer_baned_alert is sent when a peer sends too many corrupt pieces, both alerts are logged with the same message.
Building x86_64 stuff on Windows due to Gentoo syndrome.

Jabber: [email protected]
Skype: x.dayman
Irc #[email protected]: Dayman

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #23 on: November 18, 2013, 04:40:41 PM »
What Dayman said. But I think, as Doadin suggested, we should make the log string a bit more generic.

(PS: I have one last thing that I test, and I'll probably release 3.1.3 late tonight)

Doadin

  • Newbie
  • *
  • Posts: 10
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #24 on: November 18, 2013, 10:08:00 PM »
    Unfortunately it is not possible to distinguish the source of peer block.

    libtorrent sends peer_blocked_alert in any of these circumstances:
    • the IP filter
    • i2p mixed mode restrictions (a normal peer is not allowed on an i2p swarm)
    • the port filter
    • the peer has a low port and no_connect_privileged_ports is enabled
    • the protocol of the peer is blocked (uTP/TCP blocking)

    peer_baned_alert is sent when a peer sends too many corrupt pieces, both alerts are logged with the same message.

What Dayman said. But I think, as Doadin suggested, we should make the log string a bit more generic.

(PS: I have one last thing that I test, and I'll probably release 3.1.3 late tonight)

Ok, thanks guys!

PS: As noted a more generic log message would be less confusing and maybe so the code is less confusing too change the if from_ipfilter to if blocked_peer_a or something like that. I know the code doesnt make a difference in actual use but if someone wanted to help contribute it make it easyer to understand.
« Last Edit: November 18, 2013, 10:11:45 PM by Doadin »

Doadin

  • Newbie
  • *
  • Posts: 10
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #25 on: November 18, 2013, 11:17:41 PM »
I made a pull request for this but i accidentally added a different change to the same pull. Please review. Thanks.

( https://github.com/qbittorrent/qBittorrent/pull/1108 )

The DHT commit assumes that when the proxy sessions setting where consolidated in libtorrent that it still proxies DHT if this isnt the case ignore or maybe a way to notify the user maybe a good idea. However if it is, i think to protect your users it should be disabled if an unsupported proxy is in use.(What the commit does) Apparently with the DHT commit it fails to build you guys will have to chekc that i guess.
« Last Edit: November 18, 2013, 11:33:41 PM by Doadin »

rerial

  • Newbie
  • *
  • Posts: 2
  • Karma: +0/-0
    • View Profile
Re: [official]qBittorrent 3.1.2 installer - Built with MSVC 2008
« Reply #26 on: November 20, 2013, 12:19:12 AM »
silly question but does it matter if you install over an existing qbittorrent installation when updating as opposed to uninstalling it first?

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2396
  • Karma: +148/-1
    • View Profile
Re: [official]qBittorrent 3.1.3 installer - Built with MSVC 2008
« Reply #27 on: November 20, 2013, 01:52:35 AM »
Here is qBittorrent 3.1.3 built with MSVC 2008 express.

3.1.3 link-> http://sourceforge.net/projects/qbittorrent/files/qbittorrent-win32/qbittorrent-3.1.3/qbittorrent_3.1.3_setup.exe/download
Changelog: http://www.qbittorrent.org/news.php

Libraries's version used:
Libtorrent: 0.16.12+svn9305
Qt: 4.8.5
Boost: 1.55.0

100%

  • Veteran
  • ***
  • Posts: 88
  • Karma: +4/-0
    • View Profile
Re: [official]qBittorrent 3.1.3 installer - Built with MSVC 2008
« Reply #28 on: November 20, 2013, 03:18:15 PM »
Cheers, greatly appreciated!

Nemo

  • qBittorrent Forum
  • Administrator
  • Forum addict
  • *****
  • Posts: 1466
  • Karma: +90/-0
    • View Profile
Re: [official]qBittorrent 3.1.3 installer - Built with MSVC 2008
« Reply #29 on: November 20, 2013, 03:51:00 PM »
Thanks sledge, great release as always.
Forum Rules and Guidelines

Forum Admin.
Dutch & Turkish Translator.