Author Topic: Why did my thread disappear?!?!?  (Read 4899 times)

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2406
  • Karma: +150/-2
    • View Profile
Why did my thread disappear?!?!?
« on: June 23, 2011, 10:57:31 am »
Uhm, why did my thread about the unofficial builds disappear?  :-X

Nemo

  • qBittorrent Forum
  • Administrator
  • Forum addict
  • *****
  • Posts: 1477
  • Karma: +93/-0
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #1 on: June 23, 2011, 03:26:34 pm »
Huh.. Where is your topic  :o..
Forum Rules and Guidelines

Forum Admin.
Dutch & Turkish Translator.




ironcross

  • Veteran
  • ***
  • Posts: 433
  • Karma: +13/-0
    • View Profile
    • Mein Land - Call Of Duty Servers
Re: Why did my thread disappear?!?!?
« Reply #2 on: June 23, 2011, 05:27:48 pm »
I don't know nothing about that too.

Peter

  • Administrator
  • Forum addict
  • *****
  • Posts: 1579
  • Karma: +37/-2
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #3 on: June 23, 2011, 10:29:06 pm »
Uhm, why did my thread about the unofficial builds disappear?  :-X

It is due to the move, most likely.
We didn't delete it, that's for sure.

Please make a new one, and I'll sticky it.
Sorry about it.

(I knew the converter may miss things, but it reported perfect conversion without errors.)
- qBittorrent team - server and forum administrator.
- Hungarian translation reviewer/moderator (+ translator).

Join the official qBittorrent Discord!
https://discord.gg/ma66Vv4

ironcross

  • Veteran
  • ***
  • Posts: 433
  • Karma: +13/-0
    • View Profile
    • Mein Land - Call Of Duty Servers
Re: Why did my thread disappear?!?!?
« Reply #4 on: June 23, 2011, 11:06:37 pm »
But this topic was here until yesterday :o

sledgehammer_999

  • qBittorrent maintainer
  • Administrator
  • Forum addict
  • *****
  • Posts: 2406
  • Karma: +150/-2
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #5 on: June 24, 2011, 01:48:29 am »
Yep it was here until yesterday... Maybe there is bug in the new software? How about restoring it from the (possible)backup?

Peter

  • Administrator
  • Forum addict
  • *****
  • Posts: 1579
  • Karma: +37/-2
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #6 on: June 24, 2011, 01:03:07 pm »
But this topic was here until yesterday :o

You sure?
And no one deleted it?

I'll take a look at the dumps.
- qBittorrent team - server and forum administrator.
- Hungarian translation reviewer/moderator (+ translator).

Join the official qBittorrent Discord!
https://discord.gg/ma66Vv4

Peter

  • Administrator
  • Forum addict
  • *****
  • Posts: 1579
  • Karma: +37/-2
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #7 on: June 24, 2011, 01:36:45 pm »
From the dump:



ID 855:
Quote
Here is 2.6.4 compiled with the same things mentioned earlier.
USE IT AT YOUR OWN RISK
link 1-> http://http://www.megaupload.com/?d=YOF4JMJ3
link 2-> http://http://www.mediafire.com/?q1j43ayx1ebjgc5

Issues 1-4 are definetely present here. I could retest issue 5 atm.

Update on issues 2 and 3. If the *.torrent file is located at an english-only path the program works as expected. So issues 2 and 3 are connected to issue 1. They should go away as soon as issue 1 is eliminated.



ID 856:
Quote
Quote from: christophe.dumez
From our wiki:
"We are building qBittorrent on Windows with msvc compiler instead of MinGW. This choice was made because MinGW does not support wide characters. Msvc compiler also generates smaller executables than MinGW."
-&gt; Refers to: <!-- m -->http://www.mingw.org/wiki/wide_characters<!-- m -->

It explains why we gave up MinGW and why you have issues with Unicode.

I'm OK with accepting MinGW related patches in qBittorrent. However, I don't have time to spend trying to fix myself MinGW-related issues. We already have a working version (compiled with MSVC++ 2008) and this is what matters right now. Moreover, I don't believe that building with MinGW will bring anything except a bigger executable and possibly worse performance.

oh man. I completely missed that line about MingW and wide characters. :S
Anyway, I'll try to make a proper patch for winconf.pri and send it to you. Also I'll try to see what I can do about wide character support too.
Yes, the executables's size is definetely bigger, but I don't think there's a possibility for worse performance.



ID 860:
Quote
I have gotten rid of issues 1-4 and I can't reproduce issue 5 again. I have tried qbittorrent, for quite some time and it seems to work fine. But I haven't tested all of qbittorrent. There are some areas that I don't use. Like the search engine. What definitely works is: adding a torrent file, selecting a save path and actually downloading it. It doesn't matter if the path contains non-ascii characters. Everything goes where it should.

For the users:
If you give my compilation a try please let me know if it works as expected or tell me if(and what is it) a problem/bug exists. It shouldn't. If you're using it and everything is fine please let me know too. If enough people want it, I will make an installer too, but I need to see some demand for it first <!-- s:P --> :P <!-- s:P --> (or if the devs want to offer it as secondary option along with the msvc compiles).
Here are the links for qBittorrent 2.6.4 compiled with mingw-gcc 4.5.2:
link 1-&gt; http://http://www.megaupload.com/?d=K55TJQEK
link 2-&gt;http://http://www.mediafire.com/?1lrltae7370lcc8

For the developers:
1. After a lot of digging I found the culprit for the unicode problem. Qt(through QString) handles the various char set conversions correctly even though wide character support is broken in mingw. The problem arises in a function in libtorrent which, on windows, tries to convert the utf string to the native char set using windows api and wide character variables. Luckily, there are two implementations of that same function. One that uses the windows api and one that uses the libiconv api. Since, I couldn't find an easy way to enable the libiconv way on windows I just edited the file. I will make a proposition to libtorrent to be able to use libiconv even on windows. Luckily, I didn't need any other modification. The offending function is the &quot;convert_to_native()&quot; in &quot;escape_string.cpp&quot;. Here is my edited code for anyone interested(based on libtorrent 0.15.4):
Code: [Select]
/*

Copyright (c) 2003, Arvid Norberg
All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:

    * Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above copyright
      notice, this list of conditions and the following disclaimer in
      the documentation and/or other materials provided with the distribution.
    * Neither the name of the author nor the names of its
      contributors may be used to endorse or promote products derived
      from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS &quot;AS IS&quot;
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.

*/

#include &quot;libtorrent/pch.hpp&quot;

#include &lt;string&gt;
#include &lt;cctype&gt;
#include &lt;algorithm&gt;
#include &lt;limits&gt;
#include &lt;cstring&gt;

#include &lt;boost/optional.hpp&gt;
#include &lt;boost/array.hpp&gt;
#include &lt;boost/tuple/tuple.hpp&gt;

#include &quot;libtorrent/assert.hpp&quot;
#include &quot;libtorrent/escape_string.hpp&quot;
#include &quot;libtorrent/parse_url.hpp&quot;

#ifdef TORRENT_WINDOWS
#if TORRENT_USE_WPATH
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#include &lt;windows.h&gt;
#endif
#endif

#include &quot;libtorrent/utf8.hpp&quot;

//#if TORRENT_USE_LOCALE_FILENAMES
#include &lt;iconv.h&gt;
#include &lt;locale.h&gt;
//#endif

namespace libtorrent
{

   // lexical_cast's result depends on the locale. We need
   // a well defined result
   boost::array&lt;char, 3 + std::numeric_limits&lt;size_type&gt;::digits10&gt; to_string(size_type n)
   {
      boost::array&lt;char, 3 + std::numeric_limits&lt;size_type&gt;::digits10&gt; ret;
      char *p = &amp;ret.back();;
      *p = '?';
      unsigned_size_type un = n;
      if (n &lt; 0)  un = -un;
      do {
         *--p = '0' + un % 10;
         un /= 10;
      } while (un);
      if (n &lt; 0) *--p = '-';
      std::memmove(&amp;ret.front(), p, sizeof(ret.elems));
      return ret;
   }

   bool is_digit(char c)
   {
      return c &gt;= '0' &amp;&amp; c &lt;= '9';
   }

   bool is_print(char c)
   {
      return c &gt;= 32 &amp;&amp; c &lt; 127;
   }

   bool is_space(char c)
   {
      const static char* ws = &quot; tnrfv&quot;;
      return bool(std::strchr(ws, c));
   }

   char to_lower(char c)
   {
      return (c &gt;= 'A' &amp;&amp; c &lt;= 'Z') ? c - 'A' + 'a' : c;
   }

   bool string_begins_no_case(char const* s1, char const* s2)
   {
      while (*s1 != 0)
      {
         if (to_lower(*s1) != to_lower(*s2)) return false;
         ++s1;
         ++s2;
      }
      return true;
   }

   bool string_equal_no_case(char const* s1, char const* s2)
   {
      while (to_lower(*s1) == to_lower(*s2))
      {
         if (*s1 == 0) return true;
         ++s1;
         ++s2;
      }
      return false;
   }

   std::string unescape_string(std::string const&amp; s, error_code&amp; ec)
   {
      std::string ret;
      for (std::string::const_iterator i = s.begin(); i != s.end(); ++i)
      {
         if(*i == '+')
         {
            ret += ' ';
         }
         else if (*i != '%')
         {
            ret += *i;
         }
         else
         {
            ++i;
            if (i == s.end())
            {
               ec = errors::invalid_escaped_string;
               return ret;
            }

            int high;
            if(*i &gt;= '0' &amp;&amp; *i &lt;= '9') high = *i - '0';
            else if(*i &gt;= 'A' &amp;&amp; *i &lt;= 'F') high = *i + 10 - 'A';
            else if(*i &gt;= 'a' &amp;&amp; *i &lt;= 'f') high = *i + 10 - 'a';
            else
            {
               ec = errors::invalid_escaped_string;
               return ret;
            }

            ++i;
            if (i == s.end())
            {
               ec = errors::invalid_escaped_string;
               return ret;
            }

            int low;
            if(*i &gt;= '0' &amp;&amp; *i &lt;= '9') low = *i - '0';
            else if(*i &gt;= 'A' &amp;&amp; *i &lt;= 'F') low = *i + 10 - 'A';
            else if(*i &gt;= 'a' &amp;&amp; *i &lt;= 'f') low = *i + 10 - 'a';
            else
            {
               ec = errors::invalid_escaped_string;
               return ret;
            }

            ret += char(high * 16 + low);
         }
      }
      return ret;
   }

   // http://www.ietf.org/rfc/rfc2396.txt
   // section 2.3
   static const char unreserved_chars[] =
      // when determining if a url needs encoding
      // % should be ok
      &quot;%+&quot;
      // reserved
      &quot;;?:@=&amp;,$/&quot;
      // unreserved (special characters) ' excluded,
      // since some buggy trackers fail with those
      &quot;-_!.~*()&quot;
      // unreserved (alphanumerics)
      &quot;ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz&quot;
      &quot;0123456789&quot;;

   static const char hex_chars[] = &quot;0123456789abcdef&quot;;

   // the offset is used to ignore the first characters in the unreserved_chars table.
   static std::string escape_string_impl(const char* str, int len, int offset)
   {
      TORRENT_ASSERT(str != 0);
      TORRENT_ASSERT(len &gt;= 0);
      TORRENT_ASSERT(offset &gt;= 0);
      TORRENT_ASSERT(offset &lt; sizeof(unreserved_chars)-1);

      std::string ret;
      for (int i = 0; i &lt; len; ++i)
      {
         if (std::strchr(unreserved_chars+offset, *str) &amp;&amp; *str != 0)
         {
            ret += *str;
         }
         else
         {
            ret += '%';
            ret += hex_chars[((unsigned char)*str) &gt;&gt; 4];
            ret += hex_chars[((unsigned char)*str) &amp; 15];
         }
         ++str;
      }
      return ret;
   }
   
   std::string escape_string(const char* str, int len)
   {
      return escape_string_impl(str, len, 11);
   }

   std::string escape_path(const char* str, int len)
   {
      return escape_string_impl(str, len, 10);
   }

   bool need_encoding(char const* str, int len)
   {
      for (int i = 0; i &lt; len; ++i)
      {
         if (std::strchr(unreserved_chars, *str) == 0 || *str == 0)
            return true;
         ++str;
      }
      return false;
   }
   
   std::string read_until(char const*&amp; str, char delim, char const* end)
   {
      TORRENT_ASSERT(str &lt;= end);

      std::string ret;
      while (str != end &amp;&amp; *str != delim)
      {
         ret += *str;
         ++str;
      }
      // skip the delimiter as well
      while (str != end &amp;&amp; *str == delim) ++str;
      return ret;
   }

   std::string maybe_url_encode(std::string const&amp; url)
   {
      std::string protocol, host, auth, path;
      int port;
      error_code ec;
      boost::tie(protocol, auth, host, port, path) = parse_url_components(url, ec);
      if (ec) return url;
     
      // first figure out if this url contains unencoded characters
      if (!need_encoding(path.c_str(), path.size()))
         return url;

      char msg[NAME_MAX*4];
      snprintf(msg, sizeof(msg), &quot;%s://%s%s%s:%d%s&quot;, protocol.c_str(), auth.c_str()
         , auth.empty()?&quot;&quot;:&quot;@&quot;, host.c_str(), port
         , escape_path(path.c_str(), path.size()).c_str());
      return msg;
   }

   std::string base64encode(const std::string&amp; s)
   {
      static const char base64_table[] =
      {
         'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H',
         'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P',
         'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X',
         'Y', 'Z', 'a', 'b', 'c', 'd', 'e', 'f',
         'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n',
         'o', 'p', 'q', 'r', 's', 't', 'u', 'v',
         'w', 'x', 'y', 'z', '0', '1', '2', '3',
         '4', '5', '6', '7', '8', '9', '+', '/'
      };

      unsigned char inbuf[3];
      unsigned char outbuf[4];
   
      std::string ret;
      for (std::string::const_iterator i = s.begin(); i != s.end()
      {
         // available input is 1,2 or 3 bytes
         // since we read 3 bytes at a time at most
         int available_input = (std::min)(3, int(s.end()-i));

         // clear input buffer
         std::fill(inbuf, inbuf+3, 0);

         // read a chunk of input into inbuf
         std::copy(i, i + available_input, inbuf);
         i += available_input;

         // encode inbuf to outbuf
         outbuf[0] = (inbuf[0] &amp; 0xfc) &gt;&gt; 2;
         outbuf[1] = ((inbuf[0] &amp; 0x03) &lt;&lt; 4) | ((inbuf [1] &amp; 0xf0) &gt;&gt; 4);
         outbuf[2] = ((inbuf[1] &amp; 0x0f) &lt;&lt; 2) | ((inbuf [2] &amp; 0xc0) &gt;&gt; 6);
         outbuf[3] = inbuf[2] &amp; 0x3f;

         // write output
         for (int j = 0; j &lt; available_input+1; ++j)
         {
            ret += base64_table[outbuf[j]];
         }

         // write pad
         for (int j = 0; j &lt; 3 - available_input; ++j)
         {
            ret += '=';
         }
      }
      return ret;
   }

   std::string base32encode(std::string const&amp; s)
   {
      static const char base32_table[] =
      {
         'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H',
         'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P',
         'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X',
         'Y', 'Z', '2', '3', '4', '5', '6', '7'
      };

      int input_output_mapping[] = {0, 2, 4, 5, 7, 8};
     
      unsigned char inbuf[5];
      unsigned char outbuf[8];
   
      std::string ret;
      for (std::string::const_iterator i = s.begin(); i != s.end()
      {
         int available_input = (std::min)(5, int(s.end()-i));

         // clear input buffer
         std::fill(inbuf, inbuf+5, 0);

         // read a chunk of input into inbuf
         std::copy(i, i + available_input, inbuf);
         i += available_input;

         // encode inbuf to outbuf
         outbuf[0] = (inbuf[0] &amp; 0xf8) &gt;&gt; 3;
         outbuf[1] = ((inbuf[0] &amp; 0x07) &lt;&lt; 2) | ((inbuf[1] &amp; 0xc0) &gt;&gt; 6);
         outbuf[2] = ((inbuf[1] &amp; 0x3e) &gt;&gt; 1);
         outbuf[3] = ((inbuf[1] &amp; 0x01) &lt;&lt; 4) | ((inbuf[2] &amp; 0xf0) &gt;&gt; 4);
         outbuf[4] = ((inbuf[2] &amp; 0x0f) &lt;&lt; 1) | ((inbuf[3] &amp; 0x80) &gt;&gt; 7);
         outbuf[5] = ((inbuf[3] &amp; 0x7c) &gt;&gt; 2);
         outbuf[6] = ((inbuf[3] &amp; 0x03) &lt;&lt; 3) | ((inbuf[4] &amp; 0xe0) &gt;&gt; 5);
         outbuf[7] = inbuf[4] &amp; 0x1f;

         // write output
         int num_out = input_output_mapping[available_input];
         for (int j = 0; j &lt; num_out; ++j)
         {
            ret += base32_table[outbuf[j]];
         }

         // write pad
         for (int j = 0; j &lt; 8 - num_out; ++j)
         {
            ret += '=';
         }
      }
      return ret;
   }

   std::string base32decode(std::string const&amp; s)
   {
      unsigned char inbuf[8];
      unsigned char outbuf[5];
   
      std::string ret;
      for (std::string::const_iterator i = s.begin(); i != s.end()
      {
         int available_input = (std::min)(8, int(s.end()-i));

         int pad_start = 0;
         if (available_input &lt; pad_start = available_input;

         // clear input buffer
         std::fill(inbuf, inbuf+8, 0);
         for (int j = 0; j &lt; available_input; ++j)
         {
            char in = std::toupper(*i++);
            if (in &gt;= 'A' &amp;&amp; in &lt;= 'Z')
               inbuf[j] = in - 'A';
            else if (in &gt;= '2' &amp;&amp; in &lt;= '7')
               inbuf[j] = in - '2' + ('Z' - 'A') + 1;
            else if (in == '=')
            {
               inbuf[j] = 0;
               if (pad_start == 0) pad_start = j;
            }
            else if (in == '1')
               inbuf[j] = 'I' - 'A';
            else
               return std::string();
            TORRENT_ASSERT(inbuf[j] == (inbuf[j] &amp; 0x1f));
         }

         // decode inbuf to outbuf
         outbuf[0] = inbuf[0] &lt;&lt; 3;
         outbuf[0] |= inbuf[1] &gt;&gt; 2;
         outbuf[1] = (inbuf[1] &amp; 0x3) &lt;&lt; 6;
         outbuf[1] |= inbuf[2] &lt;&lt; 1;
         outbuf[1] |= (inbuf[3] &amp; 0x10) &gt;&gt; 4;
         outbuf[2] = (inbuf[3] &amp; 0x0f) &lt;&lt; 4;
         outbuf[2] |= (inbuf[4] &amp; 0x1e) &gt;&gt; 1;
         outbuf[3] = (inbuf[4] &amp; 0x01) &lt;&lt; 7;
         outbuf[3] |= (inbuf[5] &amp; 0x1f) &lt;&lt; 2;
         outbuf[3] |= (inbuf[6] &amp; 0x18) &gt;&gt; 3;
         outbuf[4] = (inbuf[6] &amp; 0x07) &lt;&lt; 5;
         outbuf[4] |= inbuf[7];

         int input_output_mapping[] = {5, 1, 1, 2, 2, 3, 4, 4, 5};
         int num_out = input_output_mapping[pad_start];

         // write output
         std::copy(outbuf, outbuf + num_out, std::back_inserter(ret));
      }
      return ret;
   }

   boost::optional&lt;std::string&gt; url_has_argument(
      std::string const&amp; url, std::string argument, size_t* out_pos)
   {
      size_t i = url.find('?');
      if (i == std::string::npos) return boost::optional&lt;std::string&gt;();
      ++i;

      argument += '=';

      if (url.compare(i, argument.size(), argument) == 0)
      {
         size_t pos = i + argument.size();
         if (out_pos) *out_pos = pos;
         return url.substr(pos, url.find('&amp;', pos) - pos);
      }
      argument.insert(0, &quot;&amp;&quot;);
      i = url.find(argument, i);
      if (i == std::string::npos) return boost::optional&lt;std::string&gt;();
      size_t pos = i + argument.size();
      if (out_pos) *out_pos = pos;
      return url.substr(pos, url.find('&amp;', pos) - pos);
   }

   TORRENT_EXPORT std::string to_hex(std::string const&amp; s)
   {
      std::string ret;
      for (std::string::const_iterator i = s.begin(); i != s.end(); ++i)
      {
         ret += hex_chars[((unsigned char)*i) &gt;&gt; 4];
         ret += hex_chars[((unsigned char)*i) &amp; 0xf];
      }
      return ret;
   }

   TORRENT_EXPORT void to_hex(char const *in, int len, char* out)
   {
      for (char const* end = in + len; in &lt; end; ++in)
      {
         *out++ = hex_chars[((unsigned char)*in) &gt;&gt; 4];
         *out++ = hex_chars[((unsigned char)*in) &amp; 0xf];
      }
      *out = '?';
   }

   int hex_to_int(char in)
   {
      if (in &gt;= '0' &amp;&amp; in &lt;= '9') return int(in) - '0';
      if (in &gt;= 'A' &amp;&amp; in &lt;= 'F') return int(in) - 'A' + 10;
      if (in &gt;= 'a' &amp;&amp; in &lt;= 'f') return int(in) - 'a' + 10;
      return -1;
   }

   TORRENT_EXPORT bool is_hex(char const *in, int len)
   {
      for (char const* end = in + len; in &lt; end; ++in)
      {
         int t = hex_to_int(*in);
         if (t == -1) return false;
      }
      return true;
   }

   TORRENT_EXPORT bool from_hex(char const *in, int len, char* out)
   {
      for (char const* end = in + len; in &lt; end; ++in, ++out)
      {
         int t = hex_to_int(*in);
         if (t == -1) return false;
         *out = t &lt;&lt; 4;
         ++in;
         t = hex_to_int(*in);
         if (t == -1) return false;
         *out |= t &amp; 15;
      }
      return true;
   }

#if TORRENT_USE_WPATH
   std::wstring convert_to_wstring(std::string const&amp; s)
   {
      std::wstring ret;
      int result = libtorrent::utf8_wchar(s, ret);
#ifndef BOOST_WINDOWS
      return ret;
#else
      if (result == 0) return ret;

      ret.clear();
      const char* end = &amp;s[0] + s.size();
      for (const char* i = &amp;s[0]; i &lt; end;)
      {
         wchar_t c = '.';
         int result = std::mbtowc(&amp;c, i, end - i);
         if (result &gt; 0) i += result;
         else ++i;
         ret += c;
      }
      return ret;
#endif
   }
#endif

/*#if defined(TORRENT_WINDOWS) &amp;&amp; !defined(TORRENT_USE_LOCALE_FILENAMES)
   std::string convert_to_native(std::string const&amp; s)
   {
#ifndef BOOST_NO_EXCEPTIONS
      try
      {
#endif
         std::wstring ws;
         libtorrent::utf8_wchar(s, ws);
         std::size_t size = wcstombs(0, ws.c_str(), 0);
         if (size == std::size_t(-1)) return s;
         std::string ret;
         ret.resize(size);
         size = wcstombs(&amp;ret[0], ws.c_str(), size + 1);
         if (size == std::size_t(-1)) return s;
         ret.resize(size);
         return ret;
#ifndef BOOST_NO_EXCEPTIONS
      }
      catch(std::exception)
      {
         return s;
      }
#endif
   }*/

//#elif TORRENT_USE_LOCALE_FILENAMES
   std::string convert_to_native(std::string const&amp; s)
   {
      // the empty string represents the local dependent encoding
      static iconv_t iconv_handle = iconv_open(&quot;&quot;, &quot;UTF-8&quot;);
      if (iconv_handle == iconv_t(-1)) return s;
      std::string ret;
      size_t insize = s.size();
      size_t outsize = insize * 4;
      ret.resize(outsize);
      char const* in = s.c_str();
      char* out = &amp;ret[0];
      size_t retval = iconv(iconv_handle, (char**)&amp;in, &amp;insize,
         &amp;out, &amp;outsize);
      if (retval == (size_t)-1) return s;
      // if this string has an invalid utf-8 sequence in it, don't touch it
      if (insize != 0) return s;
      // not sure why this would happen, but it seems to be possible
      if (outsize &gt; s.size() * 4) return s;
      ret.resize(outsize);
      return ret;
   }
//#endif

}


2. About the xp theming on common dialogs. I made some changes in winconf.pri and added 2 files. Since I am not familiar with the qmake syntax in *.pro files I am asking the devs because they sure know their way around qt/qmake. Is there a way to do &quot;conditional configuration&quot; based on preprocessor defines? eg something like:
Code: [Select]
#ifdef MINGW32 //prepare for the mingw
DEFINES +=
LIBS +=
#else //prepare for the MSVC
configure msvc-specific stuff here
#endif

Since I don't know if I can(and how) have configurations for both mingw and msvc in winconf.pri I will include my modified winconf.pri as is.
winconf.pri:
Code: [Select]
# Adapt these paths on Windows
INCLUDEPATH += $$quote(C:QBITTORRENTboost_1_45_0)
INCLUDEPATH += $$quote(C:QBITTORRENTlibtorrent-rasterbar-0.15.4include)
INCLUDEPATH += $$quote(C:/qBittorrent/RC_0_15/include)
INCLUDEPATH += $$quote(C:/qBittorrent/RC_0_15/zlib)
INCLUDEPATH += $$quote(C:/OpenSSL/include)

LIBS += $$quote(-LC:QBITTORRENTlibtorrent-rasterbar-0.15.4bingcc-mingw-4.5.2releaseboost-sourcegeoip-staticlink-staticthreading-multizlib-system)
LIBS += $$quote(-LC:QBITTORRENTboost_1_45_0stagelib)
LIBS += $$quote(-LC:/OpenSSL/lib/VC)
LIBS += $$quote(-LC:/qBittorrent/libs)


# LIBTORRENT DEFINES
DEFINES += BOOST_ALL_NO_LIB
DEFINES += BOOST_ASIO_HASH_MAP_BUCKETS=1021
DEFINES += BOOST_EXCEPTION_DISABLE
DEFINES += BOOST_SYSTEM_STATIC_LINK=1
DEFINES += BOOST_THREAD_USE_LIB
DEFINES += BOOST_THREAD_USE_LIB=1
DEFINES += TORRENT_USE_OPENSSL
DEFINES += UNICODE
DEFINES += WIN32
DEFINES += WIN32_LEAN_AND_MEAN
DEFINES += _CRT_SECURE_NO_DEPRECATE
DEFINES += _FILE_OFFSET_BITS=64
DEFINES += _SCL_SECURE_NO_DEPRECATE
DEFINES += _UNICODE
DEFINES += _WIN32
DEFINES += _WIN32_WINNT=0x0500
DEFINES += _WIN32_IE=0x0500
DEFINES += __USE_W32_SOCKETS
DEFINES += WITH_SHIPPED_GEOIP_H
DEFINES += TORRENT_USE_WPATH

CONFIG(debug, debug|release) {
  DEFINES += TORRENT_DEBUG
} else {
  DEFINES += NDEBUG
}

RC_FILE = qbittorrent_win32.rc

CONFIG(debug, debug|release) {
  LIBS += libtorrentd.lib
          libboost_system-vc90-mt-gd.lib
          libboost_filesystem-vc90-mt-gd.lib
          libboost_thread-vc90-mt-gd.lib
} else {
  LIBS += libtorrent
          libboost_system-mgw45-mt-1_45
          libboost_filesystem-mgw45-mt-1_45
          libboost_thread-mgw45-mt-1_45
}

LIBS += libadvapi32 libshell32
LIBS += libcrypto.dll libssl.dll libwsock32 libws2_32 libz libiconv.dll
LIBS += libpowrprof

DEFINES += WITH_GEOIP_EMBEDDED
message(&quot;On Windows, GeoIP database must be embedded.&quot;)

Make a copy of qbittorrent.rc and rename it to qbittorrent_win32.rc. Open qbittorrent_win32.rc and append at the end this line:
Code: [Select]
1 24 DISCARDABLE &quot;qbittorrent.exe.manifest&quot;
Make a file in the src folder named qbittorrent.exe.manifest. Open it and enter this text:
Code: [Select]
&lt;?xml version='1.0' encoding='UTF-8' standalone='yes'?&gt;
&lt;assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'&gt;
&lt;dependency&gt;
&lt;dependentAssembly&gt;
&lt;assemblyIdentity type='win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' publicKeyToken='6595b64144ccf1df' language='*' processorArchitecture='*' /&gt;
&lt;/dependentAssembly&gt;
&lt;/dependency&gt;
&lt;/assembly&gt;

At the devs: I will provide proper patches, when you provide me the required info about winconf.pri.

To anyone: Please give me feedback for anything.



ID 971:
Quote
Here is qBittorrent 2.6.7 for Windows.

link1: <!-- m -->http://www.megaupload.com/?d=U8E7K3ZH<!-- m -->
link2: <!-- m -->http://www.mediafire.com/?qt0nybiathd6o0n<!-- m -->

It is compiled with these library versions:
qt: 4.7.1
boost: 1.45.0
libtorrent: 0.15.5
openssl: 1.0.0d
zlib: 1.2.5
libiconv: 1.13.1

I couldn't build libtorrent-0.15.5 with boost-1.46.0 for some reason.



ID 991:
Quote
Here is qBittorrent 2.6.8 for Windows.

link1: <!-- m -->http://www.megaupload.com/?d=H81MCDUZ<!-- m -->
link2: <!-- m -->http://www.mediafire.com/?so77889r4rd81o8<!-- m -->

It is compiled with these library versions:
qt: 4.7.1
boost: 1.46.1
libtorrent: 0.15.5
openssl: 1.0.0d
zlib: 1.2.5
libiconv: 1.13.1

Qt compilation takes ~3 hours on my pc so I didn't compile Qt 4.7.2.

Quote from: NeMo_0
No it actually works quite good didn't find or saw any bugs or whatsoever, an installer would be handy indeed

I'll see what I can do for an installer. For the time being, enjoy 2.6.8 :p
- qBittorrent team - server and forum administrator.
- Hungarian translation reviewer/moderator (+ translator).

Join the official qBittorrent Discord!
https://discord.gg/ma66Vv4

Peter

  • Administrator
  • Forum addict
  • *****
  • Posts: 1579
  • Karma: +37/-2
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #8 on: June 24, 2011, 01:38:05 pm »
Just press Quote at my post, so you can re-post all the info if you need.
(Tried, but I just can't reinsert the thread ... it's not that simple.There is a good GUI for SQL, for MAC.)
- qBittorrent team - server and forum administrator.
- Hungarian translation reviewer/moderator (+ translator).

Join the official qBittorrent Discord!
https://discord.gg/ma66Vv4

ironcross

  • Veteran
  • ***
  • Posts: 433
  • Karma: +13/-0
    • View Profile
    • Mein Land - Call Of Duty Servers
Re: Why did my thread disappear?!?!?
« Reply #9 on: June 24, 2011, 04:09:21 pm »
But this topic was here until yesterday :o

You sure?
And no one deleted it?

I'll take a look at the dumps.

Absolutely sure, the topic was here. Also i'm sure i'm not deleted it.
The last thing i did as admin was to fix the Quck Reply textarea in the green theme. It was overly wide and there was a complaint from loki. I did a simple edit in the theme's index.css:
it was
Code: [Select]
#quickReplyOptions form textarea
{
height: 100px;
margin: 0.25em 0 1em 0;
}
i made it
Code: [Select]
#quickReplyOptions form textarea
{
height: 100px;
width: 635px;
max-width: 100%;
min-width: 100%;
margin: 0.25em 0 1em 0;
}
Loki was opened a topic about that in Suggestions. But that was not suggestion, it was some problem with the new SMF theme, so i merged loki's topic with the SMF topic in the Cafe Lounge. Then i fixed the problem as i said above. No one of these actions can't affect sledgehammer's topic and his topic was here.

Edit: I found something about recovering deleted topic in SMF. It's about older SMF version, but maybe it can be used:
http://www.prettyscripts.com/software/smf/smf-recover-deleted-topic
« Last Edit: June 24, 2011, 04:14:43 pm by ironcross »

Peter

  • Administrator
  • Forum addict
  • *****
  • Posts: 1579
  • Karma: +37/-2
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #10 on: June 25, 2011, 12:13:55 am »
I'll check out the link, seems like I'll be able to use it.
- qBittorrent team - server and forum administrator.
- Hungarian translation reviewer/moderator (+ translator).

Join the official qBittorrent Discord!
https://discord.gg/ma66Vv4

Nemo

  • qBittorrent Forum
  • Administrator
  • Forum addict
  • *****
  • Posts: 1477
  • Karma: +93/-0
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #11 on: August 03, 2011, 10:32:44 pm »
Sledge will you be uploading v2.8.3 also? Using your builds for a while now without problems :).
Forum Rules and Guidelines

Forum Admin.
Dutch & Turkish Translator.




loki

  • Forum addict
  • ****
  • Posts: 567
  • Karma: +16/-1
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #12 on: August 04, 2011, 12:03:35 am »
sledgehammer is supposedly offline for the rest of summer...

Tomaso

  • Veteran
  • ***
  • Posts: 266
  • Karma: +18/-0
  • Norwegian translator
    • View Profile
Re: Why did my thread disappear?!?!?
« Reply #13 on: August 04, 2011, 01:17:55 am »
..and Dib is on vacation until Aug.23rd.
Guess we'll have to wait a while for v2.8.3.

ironcross

  • Veteran
  • ***
  • Posts: 433
  • Karma: +13/-0
    • View Profile
    • Mein Land - Call Of Duty Servers
Re: Why did my thread disappear?!?!?
« Reply #14 on: August 04, 2011, 08:01:19 am »
I can wait. 2.8.2 works fine for me.