[official]qBittorrent 3.1.12 installer - Built with MSVC 2013

Testing the freshly baked, latest builds!
sledgehammer_999
Administrator
Administrator
Posts: 2443
Joined: Sun Jan 23, 2011 1:17 pm

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by sledgehammer_999 »

When they move to peer id show them this:  https://github.com/qbittorrent/qBittorr ... nt_Peer_ID

This is the particular line from qbt source for user agent:

Code: Select all

sessionSettings.user_agent = "qBittorrent "VERSION;
and VERSION is defined as:

Code: Select all

v3.1.11
Maybe a wireshark capture would shed some light on that.
Muzak

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by Muzak »

Thanks, I'll probably have to wireshark it, something funky is going on, probably something with my connection....
Muzak

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by Muzak »

Turns out they were using the Peer ID and had some regx code to split the peer id up and it broke on having a letter in the version.  Took me quite a bit of head scratching to come up with the fix, but all is good now, they updated the code and it's all good.....  Did I mention how much I hate regx????

FWIW, the current PeerId for 3.1.10 and 3.1.11 violate the "convention" for peer ids (I just received a mini-education on why my patch was wrong, even though it wasn't....hehehe)
https://wiki.theory.org/BitTorrentSpecification#peer_id
Last edited by Muzak on Wed Nov 05, 2014 10:02 pm, edited 1 time in total.
sledgehammer_999
Administrator
Administrator
Posts: 2443
Joined: Sun Jan 23, 2011 1:17 pm

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by sledgehammer_999 »

I think the keyword here is "ascii digits".
sledgehammer_999
Administrator
Administrator
Posts: 2443
Joined: Sun Jan 23, 2011 1:17 pm

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by sledgehammer_999 »

Yeap. Here is an excerpt from include/libtorrent/fingerprint.hpp (libtorrent 1.0.3):

Code: Select all

char version_to_char(int v) const
		{
			if (v >= 0 && v < 10) return '0' + v;
			else if (v >= 10) return 'A' + (v - 10);
			TORRENT_ASSERT(false);
			return '0';
		}
Libtorrent allows to construct the peer id by providing the fingerprint class a 2 character string, and 4 integers for major,minor,revision,tag versions. Each interger is converted to ascii using the above function.
Numbers 0-9 are converted to their equivalent ascii code(aka number).
All others are converted to the ascii code of 'A' plus their number.(minus 10).
Note: In C/C++ when you enclose something in single quotes it is treated as a character not as a number. So in this case '0' converted to number means 48 (the ascii code for zero).

EDIT: variables of type char can be treated in 2 ways: represent an actual character or represent a number(255 possible values).
Last edited by sledgehammer_999 on Sat Nov 08, 2014 11:46 pm, edited 1 time in total.
KManju

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by KManju »

I'm not sure if this is the right place to ask this, but I am new to the forums and qBittorrent, and haven't had a chance to fully explore. I know that with some torrent clients, the 12 bytes of padding in the peer id are static and are used as a unique id of sorts. I was wondering if this was the case with 3.1.11, and if so, is there anyway to change it other than enabling the 'anonymous mode' which unfortunately disables DHT and PEX.
sledgehammer_999
Administrator
Administrator
Posts: 2443
Joined: Sun Jan 23, 2011 1:17 pm

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by sledgehammer_999 »

The padding should be random. At least that is what the libtorrent docs say.
There is no way for an end-user to spoof the peer-id. (qbt would be banned immediately by every tracker if there was such a possibility).
I am not sure, but I think libtorrent 1.0.x allows dht/pex with anonymous mode. You should try the alpha builds in the "windows development" section of the forum. They use libtorrent 1.0.x. (the v3.1.x series aren't compatible with that)
Muzak

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by Muzak »

Per libtorrent the 12 bytes are random each time you start the client.  They don't change until you close and reopen the client.  Most sites frown on this being changed during the client session.
sledgehammer_999
Administrator
Administrator
Posts: 2443
Joined: Sun Jan 23, 2011 1:17 pm

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by sledgehammer_999 »

Here is qBittorrent 3.1.12 built with MSVC 2013 express.

3.1.12 link-> http://www.fosshub.com/qBittorrent.html
Changelog: http://www.qbittorrent.org/news.php

Libraries's version used:
Libtorrent: 0.16.19+svn10736
Qt: 4.8.6
Boost: 1.55.0

As you may have noticed I have changed to using msvc 2013 instead of msvc 2008(these are compilers). I want Windows XP users to tell me if it works on their system. I tested it on a clean Windows XP VM and it works for me.
Henry63

Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013

Post by Henry63 »

I just installed Win8.1 yesterday and 3.1.11 installed just fine but 3.1.12 is making Win8.1 want to block the install program from running. Claims it's "unsafe". I assume it's a false positive of some sort.
sledgehammer_999
Administrator
Administrator
Posts: 2443
Joined: Sun Jan 23, 2011 1:17 pm

Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013

Post by sledgehammer_999 »

[quote="Henry63"]
I just installed Win8.1 yesterday and 3.1.11 installed just fine but 3.1.12 is making Win8.1 want to block the install program from running. Claims it's "unsafe". I assume it's a false positive of some sort.
[/quote]

Are you refering to the UAC dialog or to some kind of antivirus warning?
In the past some antivirus programs gave false positives for our installers... This might be it. My avast shows it as clean.
Henry63

Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013

Post by Henry63 »

I just have a stock Pro install(no custom anti-malware or anything, just games and "normal" programs), but it was like a UAC thing, where the entire screen turned grey and a message bar went across the middle saying that the program was blocked. MsMpEng has been running in the background for a quite a while now, from what I found, it's probably "learning" the new system.

I just recently tried it again and it is no longer being blocked, but I did try it a few times before originally posting. I guess I'll just assume MsMpEng was being overly paranoid or something. I kicked off a full scan, I read this can help it learn faster or something.
tekko

Re: [official]qBittorrent 3.1.11 installer - Built with MSVC 2008

Post by tekko »

[quote="sledgehammer_999"]
Here is qBittorrent 3.1.12 built with MSVC 2013 express.

3.1.12 link-> http://www.fosshub.com/qBittorrent.html
Changelog: http://www.qbittorrent.org/news.php

Libraries's version used:
Libtorrent: 0.16.19+svn10736
Qt: 4.8.6
Boost: 1.55.0

As you may have noticed I have changed to using msvc 2013 instead of msvc 2008(these are compilers). I want Windows XP users to tell me if it works on their system. I tested it on a clean Windows XP VM and it works for me.
[/quote]


xpsp3... main os, not vm
no problem yet.
User avatar
Nemo
Administrator
Administrator
Posts: 1730
Joined: Sat Jul 24, 2010 6:24 pm

Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013

Post by Nemo »

Thanks sledge.
100%

Re: [official]qBittorrent 3.1.12 installer - Built with MSVC 2013

Post by 100% »

qBt v3.1.12 is working great, thanks guys!
Post Reply